Add project key for agent comms by potofpie · Pull Request #285 · agentuity/cli

potofpie · 2025-05-08T20:17:52Z

No description provided.

jhaynie · 2025-05-12T01:13:14Z

 		if envLine.Key == "AGENTUITY_API_KEY" {
 			envLines[i].Val = apikey
-			found = true
+			found["AGENTUITY_API_KEY"] = true


i've made this comment several times but it doesn't seem to stick...

AGENTUITY_AGENTS_KEY seems confusing to me. Is this the project-level key for the agent or the key to use for the SDK?

i think we should maybe be more intentional in the naming.

AGENTUITY_SDK_KEY - this would be current AGENTUITY_API_KEY but make it clear that it's needed for the SDK to run.

AGENTUITY_PROJECT_KEY - this would be what I think is your AGENTUITY_AGENTS_KEY but be the project-level key for accessing agents within the same project.

We would need to make AGENTUITY_API_KEY backwards compatible so i realize that this is a little more work but i think would make it more clear what is what.

Yep! I was in the process of making that change Thursday and and pick it back up now. 👍

jhaynie

LGTM

potofpie · 2025-05-12T19:20:25Z

+		"AGENTUITY_PROJECT_KEY": false,
+	}
+
 	for i, envLine := range envLines {


jhaynie · 2025-05-13T13:32:44Z


-	if !found["AGENTUITY_SDK_KEY"] {
-		envLines = append(envLines, env.EnvLine{Key: "AGENTUITY_SDK_KEY", Val: apikey})
+	gtVersion := version.GreaterThan(semver.MustParse("0.0.114"))


different versions between python and js.

jhaynie · 2025-05-13T13:34:06Z

+
 	if !found["AGENTUITY_PROJECT_KEY"] {
 		envLines = append(envLines, env.EnvLine{Key: "AGENTUITY_PROJECT_KEY", Val: projectKey})
 	}


i'm wondering if we need all of this. since this version of the CLI that's executing and our network will support the new variable, why not just detect if we have the old one and remove it and replace it with the new one and not worry about the SDK version at all?

🤔 I think that would work for deployed projects but we'd something like this for devmode.

maybe we can think of a simpler way to solve that problem tho.

jhaynie · 2025-05-13T17:00:19Z

+		Runtime: "bunjs",
+		Version: "<0.0.115",
+		Title:   "🚫 JS SDK Breaking Change 🚫",
+		Message: "The environment variable and code reference for your Agentuity API key has changed from AGENTUITY_API_KEY to AGENTUITY_SDK_KEY. Update all occurrences in your .env files and codebase. See the v0.0.114 Changelog for details.\n\n" + tui.Link("https://agentuity.dev/Changelog/sdk-js#v00114") + "\n\nAfter migrated, please run bun update @agentuity/sdk --latest and then re-run this command again.",


shouldn't the message be 0.0.115?

jhaynie · 2025-05-13T17:00:28Z

+		Runtime: "nodejs",
+		Version: "<0.0.115 ",
+		Title:   "🚫 JS SDK Breaking Change 🚫",
+		Message: "The environment variable and code reference for your Agentuity API key has changed from AGENTUITY_API_KEY to AGENTUITY_SDK_KEY. Update all occurrences in your .env files and codebase. See the v0.0.114 Changelog for details.\n\n" + tui.Link("https://agentuity.dev/Changelog/sdk-js#v00114") + "\n\nAfter migrated, please run npm i @agentuity/sdk --latest and then re-run this command again.",


jhaynie · 2025-05-13T17:00:41Z

+		Runtime: "uv",
+		Version: "<0.0.84",
+		Title:   "🚫 Python SDK Breaking Changes 🚫",
+		Message: "The environment variable and code reference for your Agentuity API key has changed from AGENTUITY_API_KEY to AGENTUITY_SDK_KEY. Update all occurrences in your .env files and codebase. See the v0.0.114 Changelog for details.\n\n" + tui.Link("https://agentuity.dev/Changelog/sdk-js#v00114") + "\n\nAfter migrated, please run `uv add agentuity -U` --latest and then re-run this command again.",


fix version

jhaynie · 2025-05-13T22:41:48Z

+		Runtime: "nodejs",
+		Version: "<0.0.115 ",
+		Title:   "🚫 JS SDK Breaking Change 🚫",
+		Message: "The environment variable and code reference for your Agentuity API key has changed from AGENTUITY_API_KEY to AGENTUITY_SDK_KEY. Update all occurrences in your .env files and codebase. See the v0.0.115 Changelog for details.\n\n" + tui.Link("https://agentuity.dev/Changelog/sdk-js#v00114") + "\n\nAfter migrated, please run npm i @agentuity/sdk --latest and then re-run this command again.",


link is wrong on these still

dammit my bad.

jhaynie

💯

robindiddams

looks good

Co-authored-by: Robin Diddams <robindiddams@gmail.com>

potofpie added 2 commits April 24, 2025 15:06

cli changes

c524087

Merge branch 'main' of https://github.com/agentuity/cli into agents_key

0a9f2e2

jhaynie reviewed May 12, 2025

View reviewed changes

potofpie added 4 commits May 12, 2025 12:29

added changes to support project auth token

0b5d38a

alomst there

5e18caa

I think this is backward compatable

ece25b0

added one more check

ed2b2cb

potofpie changed the title ~~Agents key~~ Add project key for agent comms May 12, 2025

potofpie requested a review from jhaynie May 12, 2025 18:36

jhaynie approved these changes May 12, 2025

View reviewed changes

potofpie commented May 12, 2025

View reviewed changes

Comment thread cmd/project.go

"AGENTUITY_PROJECT_KEY": false,

}

for i, envLine := range envLines {

Copy link
Copy Markdown

Member Author

potofpie May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

better dx

1f75ce9

jhaynie suggested changes May 13, 2025

View reviewed changes

add version map

ed61e0c

potofpie marked this pull request as ready for review May 13, 2025 14:27

Merge branch 'main' of https://github.com/agentuity/cli into agents_key

81dd4a0

potofpie requested a review from jhaynie May 13, 2025 14:41

going I different route

6fb447a

potofpie requested review from pec1985 and robindiddams May 13, 2025 16:44

jhaynie suggested changes May 13, 2025

View reviewed changes

added version

16196d5

potofpie requested a review from jhaynie May 13, 2025 18:03

exit after migration

f110244

jhaynie suggested changes May 13, 2025

View reviewed changes

added right link

96f4d92

potofpie requested a review from jhaynie May 13, 2025 22:52

jhaynie approved these changes May 14, 2025

View reviewed changes

robindiddams reviewed May 14, 2025

View reviewed changes

Comment thread cmd/project.go Outdated

Comment thread cmd/project.go

Update cmd/project.go

6a5e9e1

Co-authored-by: Robin Diddams <robindiddams@gmail.com>

Update cmd/project.go

cfa19ff

Co-authored-by: Robin Diddams <robindiddams@gmail.com>

potofpie merged commit 7040e58 into main May 14, 2025
14 checks passed

potofpie deleted the agents_key branch May 14, 2025 12:59

Conversation

potofpie commented May 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhaynie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhaynie left a comment

Choose a reason for hiding this comment

Uh oh!

robindiddams left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants